Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1281-properties-ux #1310

Merged
merged 3 commits into from
Dec 13, 2024
Merged

1281-properties-ux #1310

merged 3 commits into from
Dec 13, 2024

Conversation

pablo-mayrgundter
Copy link
Member

@pablo-mayrgundter pablo-mayrgundter commented Dec 13, 2024 •
edited
Loading

Fixes #1281. Partly addresses #1280.

  • Props: use carat open/close icon.
  • NavTree: replace custom open/close icon with mui carat.
  • Snack: fix colors.
  • Removed some old config from theme/Components, and converted all theme.palette to just use the scoped palette

@pablo-mayrgundter pablo-mayrgundter added the bug Something isn't working label Dec 13, 2024
@pablo-mayrgundter pablo-mayrgundter self-assigned this Dec 13, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 13, 2024 •
edited
Loading

✅ Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit 1026405
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/675b94e17fbb5800086b635f
😎 Deploy Preview https://deploy-preview-1310--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 0 (no change from production)
Accessibility: 89 (🟢 up 2 from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 13, 2024 •
edited
Loading

✅ Deploy Preview for bldrs-share-prod ready!

Name Link
🔨 Latest commit 1026405
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-prod/deploys/675b94e1a49dd60008d7b103
😎 Deploy Preview https://deploy-preview-1310--bldrs-share-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

nickcastel50
nickcastel50 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@nickcastel50 nickcastel50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablo-mayrgundter pablo-mayrgundter merged commit 55e8dbe into bldrs-ai:main Dec 13, 2024
10 checks passed
@pablo-mayrgundter pablo-mayrgundter deleted the 1281-properties-ux branch December 13, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickcastel50 nickcastel50 nickcastel50 approved these changes

Assignees

@pablo-mayrgundter pablo-mayrgundter

Labels
bug Something isn't working
Projects
Sprints
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Properties UX
2 participants
@pablo-mayrgundter @nickcastel50